lxd/network/acl: return ACL logs from syslogs when the OVN controller is deployed in MicroOVN #14327
+109
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmougard
force-pushed
the
fix/microovn-logs
branch
from
ddd4d19
to
af03834
Compare
gabrielmougard
changed the title
gabrielmougard
force-pushed
the
fix/microovn-logs
branch
4 times, most recently
from
95e766e
to
d4828be
Compare
In the case of an OVN controller being deployed as part of a MicroOVN deployment, the OVN controller logs are stored in MicroOVN's snap syslog. The LXD snap should have root access, which means that it should be authorized (this is being tested) to read the OVN controller logs. Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
… from syslogs If the OVN controller is deployed as part of MicroOVN, it means that the `ovn-chassis` snap connection hook between LXD and MicroOVN has been fired and that a symlink like: `/run/openvswitch -> /var/snap/lxd/<ID>/microovn/...` exists. Otherwise, there might still be a symlink but not with that target prefix. That's how we detect the ovn chassis connection without introducing a new plug / slot between LXD and MicroOVN. Then, if this case is detected, we check the status of the systemd unit 'snap.microovn.chassis.service' (the one containing the OVN controller in its sd journal) If it is loaded and active, we read the last 5000 ACL log entries (we can discuss on this limit) in the journal and return them. Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
gabrielmougard
force-pushed
the
fix/microovn-logs
branch
from
d4828be
to
316aeed
Compare
|
@tomponline this should be working. Regarding the documentation, as we discussed earlier, we probably need to add a note in the doc section |
|
Here is the lxd-ci PR: canonical/lxd-ci#330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12836