Skip to content

Commit

Permalink
Merge pull request #86 from bytedance/use-template-to-generate-fullname
Browse files Browse the repository at this point in the history
fix: Use template to generate fullname instead of using fixed resourc…
  • Loading branch information
Danny-Wei authored Jun 6, 2024
2 parents dc20350 + 0e18690 commit 4a181d5
Show file tree
Hide file tree
Showing 14 changed files with 25 additions and 43 deletions.
22 changes: 2 additions & 20 deletions manifests/varmor/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,7 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
If release name contains chart name it will be used as a full name.
*/}}
{{- define "varmor.manager.fullname" -}}
{{- if .Values.fullnameOverride }}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
{{- if contains $name .Release.Name }}
{{- printf "%s-%s" .Release.Name .Values.manager.name | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- printf "%s-%s-%s" .Release.Name $name .Values.manager.name | trunc 63 | trimSuffix "-" }}
{{- end }}
{{- end }}
{{- printf "varmor-%s" .Values.manager.name | trunc 63 | trimSuffix "-" }}
{{- end }}

{{- define "varmor.manager.labels" -}}
Expand Down Expand Up @@ -110,16 +101,7 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
If release name contains chart name it will be used as a full name.
*/}}
{{- define "varmor.agent.fullname" -}}
{{- if .Values.fullnameOverride }}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
{{- if contains $name .Release.Name }}
{{- printf "%s-%s" .Release.Name .Values.agent.name | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- printf "%s-%s-%s" .Release.Name $name .Values.agent.name | trunc 63 | trimSuffix "-" }}
{{- end }}
{{- end }}
{{- printf "varmor-%s" .Values.agent.name | trunc 63 | trimSuffix "-" }}
{{- end }}

{{- define "varmor.agent.labels" -}}
Expand Down
4 changes: 2 additions & 2 deletions manifests/varmor/templates/daemonsets/agent.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.agent.labels" . | nindent 4 }}
Expand All @@ -20,7 +20,7 @@ spec:
{{- toYaml . | nindent 6 }}
{{- end }}
{{- end }}
serviceAccountName: varmor-agent
serviceAccountName: {{ include "varmor.agent.serviceAccountName" . }}
securityContext:
{{- toYaml .Values.agent.podSecurityContext | nindent 8 }}
containers:
Expand Down
2 changes: 1 addition & 1 deletion manifests/varmor/templates/deployments/classifier.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: varmor-classifier
name: {{ include "varmor.classifier.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.classifier.labels" . | nindent 4 }}
Expand Down
4 changes: 2 additions & 2 deletions manifests/varmor/templates/deployments/manager.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.manager.labels" . | nindent 4 }}
Expand All @@ -27,7 +27,7 @@ spec:
{{- toYaml . | nindent 6 }}
{{- end }}
{{- end }}
serviceAccountName: varmor-manager
serviceAccountName: {{ include "varmor.manager.serviceAccountName" . }}
securityContext:
{{- toYaml .Values.manager.podSecurityContext | nindent 8 }}
containers:
Expand Down
2 changes: 1 addition & 1 deletion manifests/varmor/templates/rbac/agent-clusterrole.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
labels:
{{- include "varmor.agent.labels" . | nindent 4 }}
rules:
Expand Down
6 changes: 3 additions & 3 deletions manifests/varmor/templates/rbac/agent-clusterrolebinding.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
labels:
{{- include "varmor.agent.labels" . | nindent 4 }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
subjects:
- kind: ServiceAccount
name: varmor-agent
name: {{ include "varmor.agent.serviceAccountName" . }}
namespace: {{ include "varmor.namespace" . }}
2 changes: 1 addition & 1 deletion manifests/varmor/templates/rbac/agent-role.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.agent.labels" . | nindent 4 }}
Expand Down
6 changes: 3 additions & 3 deletions manifests/varmor/templates/rbac/agent-rolebinding.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.agent.labels" . | nindent 4 }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: varmor-agent
name: {{ include "varmor.agent.fullname" . }}
subjects:
- kind: ServiceAccount
name: varmor-agent
name: {{ include "varmor.agent.serviceAccountName" . }}
namespace: {{ include "varmor.namespace" . }}
2 changes: 1 addition & 1 deletion manifests/varmor/templates/rbac/agent-serviceaccount.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: varmor-agent
name: {{ include "varmor.agent.serviceAccountName" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.agent.labels" . | nindent 4 }}
Expand Down
2 changes: 1 addition & 1 deletion manifests/varmor/templates/rbac/manager-clusterrole.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
labels:
{{- include "varmor.manager.labels" . | nindent 4 }}
rules:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
labels:
{{- include "varmor.manager.labels" . | nindent 4 }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
subjects:
- kind: ServiceAccount
name: varmor-manager
name: {{ include "varmor.manager.serviceAccountName" . }}
namespace: {{ include "varmor.namespace" . }}
2 changes: 1 addition & 1 deletion manifests/varmor/templates/rbac/manager-role.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.manager.labels" . | nindent 4 }}
Expand Down
6 changes: 3 additions & 3 deletions manifests/varmor/templates/rbac/manager-rolebinding.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.manager.labels" . | nindent 4 }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: varmor-manager
name: {{ include "varmor.manager.fullname" . }}
subjects:
- kind: ServiceAccount
name: varmor-manager
name: {{ include "varmor.manager.serviceAccountName" . }}
namespace: {{ include "varmor.namespace" . }}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: varmor-manager
name: {{ include "varmor.manager.serviceAccountName" . }}
namespace: {{ include "varmor.namespace" . }}
labels:
{{- include "varmor.manager.labels" . | nindent 4 }}
Expand Down

0 comments on commit 4a181d5

Please sign in to comment.