arm: Implement SVE2 str2int #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermartian
force-pushed
the
sve2-str2int
branch
2 times, most recently
from
895c590
to
5b2d104
Compare
|
@supermartian format codes with clang-format |
This patch implements a SVE2 version of str2int which improves number decoding on ARM SVE2 CPUs. The algorithm utilizes SVMATCH to count valid digits in the string, and SDOT for calculating the value. With this change the naive byte-by-byte method for ARM is substituted. Enable it by compiling with adding cmake option "-DENABLE_SVE2_128=ON". | Benchmark | Original | SVE2 | Improvement | |--------------------------------|--------------|------------|-------------| | testdata/gsoc-2018.json | 3406307500 | 3407847500 | 0.05% | | testdata/twitter.json | 2040162500 | 2039502500 | -0.03% | | testdata/fgo.json | 992470750 | 988730000 | -0.38% | | testdata/citm_catalog.json | 2209855000 | 2205997500 | -0.17% | | testdata/twitterescaped.json | 1767812500 | 1814302500 | 2.63% | | testdata/github_events.json | 2142690000 | 2147452500 | 0.22% | | testdata/lottie.json | 625985250 | 602068500 | -3.82% | | testdata/poet.json | 2867745000 | 2880562500 | 0.45% | | testdata/otfcc.json | 685481500 | 683760750 | -0.25% | | testdata/book.json | 687309000 | 674716000 | -1.83% | | testdata/canada.json | 775475000 | 1051945000 | 35.65% | Signed-off-by: Yuzhong Wen <yuwen@nvidia.com>
supermartian
force-pushed
the
sve2-str2int
branch
from
5b2d104
to
f571d3e
Compare
Thanks for the review! Formatting done. |
|
Does the v1.0.1 release version support ARM architecture CPUs? |
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a SVE2 version of str2int which improves number decoding on ARM SVE2 CPUs.
The algorithm utilizes SVMATCH to count valid digits in the string, and SDOT for calculating the value. With this change the naive byte-by-byte method for ARM is substituted. Note that these instructions are SVE2 only.
Enable it by compiling with adding cmake option "-DENABLE_SVE2_128=ON".
Numbers were tested on NVIDIA Grace.
This PR is contributed by NVIDIA