Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add Tests #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Add Tests #3

wants to merge 4 commits into from

Conversation

erickhun
Copy link
Collaborator

@erickhun erickhun commented Feb 24, 2020 •
edited
Loading

The challenge here is to gather what will be sent to stdout:

some solutions:

  • redirect the logs to a file and test the file
  • use pino metadata

@erickhun erickhun mentioned this pull request Feb 24, 2020
Merged
@erickhun
Copy link
Collaborator Author

note :
@djfarrelly had a smart way to test stdout with its StdoutCapture function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erickhun