Add support to exclude by application name on txn_* checks #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to check the PostgreSQL version because the "application_name" was introduced in 9.0 version. |
|
Yes, you are right there. I guess we could just ignore the whole --{exclude|include}app options if they are running a version older then 9.0, and add in the docs that this is only available for PostgreSQL >= 9.0 The other option would be to fail with an error message on older versions. I really don't like that. And the user should read the docs first. |
long idle in transaction. Good for filtering applications like pg_dump, but also others without having to run them with a specific user.
that haven't been set and are needed.
… it's hard, or imposible to know which index is bloated if there are indexes with the same name in different schemas. Here we add the schema to the bloat message when finding bloat in indexes.
Newer versions will show the last or current query here, older versions will just show "<IDLE> in transaction" if there is currently no query running.
... and note author of last commit in changelog
set_translations.pl only wrote output for languages seen in .po files,
dropping other previously known languages.
Also, fix output to honor the current indentation style (no tabs). In
order to change the current formatting as little as possible, set the
minimal output key output width to 14, and no not append a space after
'key' ('checkcluster-nomrtg' is otherwise too long).
…eruser. The wrapper function around pg_ls_dir() must hardcode the pg_xlog or pgxlog/archive_status path, and should take no arguments. It must be created as a superuser with SECURITY DEFINER.
In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790231, Daniel Schepler reports pbuilder (a throwaway-minimal-chroot build wrapper for Debian packages) to setup the filesystem name to be shown as "-". Allow this in the testsuite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 chsets: