Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Add open on Merge Request link in brower #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kyoshidajp
Copy link

Hi.

I added function that open Merge Request link in browser. It's like a function "Open on GitLab". Difference is open Merge Request link on current line.

And I changed code drastically because of this function.

@kyoshidajp kyoshidajp closed this Feb 28, 2016
@kyoshidajp kyoshidajp deleted the open_merge_request_link branch February 28, 2016 02:47
@kyoshidajp kyoshidajp restored the open_merge_request_link branch February 28, 2016 02:48
@kyoshidajp
Copy link
Author

Sorry, I made a mistake git operation.

@kyoshidajp kyoshidajp reopened this Feb 28, 2016
try {
fileAnnotation = annotationProvider.annotate(virtualFile);
} catch (VcsException e1) {
e1.printStackTrace();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, don't use .printStackTrace()

@kyoshidajp
Copy link
Author

I changed. Anything else?

}
}

class RemoteSelectedBaseAction extends AnAction {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is too big. Could you please extract it to the separate file and make public?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants