googlebigtable2 - add binding for the current client api #1727
Conversation
The existing googlebigtable binding uses an old client (bigtable-client-core) which is frozen and unmaintained. The new binding adds support for google-cloud-bigtable client
googlebigtable2/src/main/java/site/ycsb/db/GoogleBigtable2Client.java
Outdated
Show resolved
Hide resolved
| Optional<String> emulatorHost = | ||
| Optional.ofNullable(System.getenv().get("BIGTABLE_EMULATOR_HOST")); | ||
| Optional<String> dataEndpoint = Optional.ofNullable(props.getProperty(ENDPOINT_KEY)); | ||
| if (emulatorHost.isPresent()) { |
There was a problem hiding this comment.
Is this ever used? I don't think it's ever connected to the emulator?
There was a problem hiding this comment.
its used by the client and this is just to avoid conflicts between endpoint and BIGTABLE_EMULATOR_HOST values
| .map(Boolean::parseBoolean) | ||
| .orElse(false); | ||
|
|
||
| Optional.ofNullable(props.getProperty(MAX_OUTSTANDING_BYTES)) |
There was a problem hiding this comment.
why making max outstadning bytes configurable?
There was a problem hiding this comment.
I think patrick overrides this in internal tests
| /** | ||
| * Tracks running thread counts so we know when to close the session. | ||
| */ | ||
| private static int clientRefCount = 0; |
There was a problem hiding this comment.
should this be atomicInteger or volatile?
There was a problem hiding this comment.
its only ever updated in synchronized methods
| mapToMutation(values, m); | ||
| getBatcher(table).add(m); | ||
|
|
||
| return Status.BATCHED_OK; |
There was a problem hiding this comment.
If there are individual failures should we still return OK status?
There was a problem hiding this comment.
I dont think ycsb has any way to deal with batch entry failures :(
The existing googlebigtable binding uses an old client (bigtable-client-core) which is frozen and unmaintained. The new binding adds support for google-cloud-bigtable client