Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spell: dictionary input loop #335

Merged
merged 1 commit into from
Nov 21, 2023
Merged

spell: dictionary input loop #335

merged 1 commit into from
Nov 21, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 19, 2023

  • Rewrite word file input loop with explicit close() and without tmp_words list
  • Delete commented code
  • Simpler usage() which doesn't take a parameter
  • Test provides same output as previous version: pod2text bc | perl spell -b/usr/share/dict/words

Output I cherry-pick for no particular reason:
assigment
assignent
generats

@mknos
spell: dictionary input loop
7d2cb30 
* Rewrite word file input loop with explicit close() and without tmp_words list
* Delete commented code
* Simpler usage() which doesn't take a parameter
* Test provides same output as previous version: pod2text bc | perl spell -b/usr/share/dict/words

Output I cherry pick for no particular reason:
assigment
assignent
generats
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: spell The spell program labels Nov 19, 2023
@briandfoy briandfoy self-assigned this Nov 21, 2023
@briandfoy briandfoy merged commit 6cda094 into briandfoy:master Nov 21, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: spell The spell program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy