feat: Add table entries to properties panel #912

vsgoulart · 2023-11-23T15:13:45Z

Closes #890

This PR adds a new form-js element or visually changes an existing component.
- => In that case, we need to ensure we follow up on this, e.g. by creating an issue in Tasklist

packages/form-js-editor/src/features/properties-panel/entries/TextEntry.js

vsgoulart · 2023-11-23T15:25:39Z

packages/form-js-editor/src/features/properties-panel/entries/ColumnEntry.js

The logic of the the static column headers is sort of similar with the static options in the select, but I think they're not that related to be worth it to create a common reusable component

packages/form-js-editor/src/features/properties-panel/entries/TableDataSourceEntry.js

packages/form-js-editor/src/features/properties-panel/entries/LabelEntry.js

pinussilvestrus · 2023-11-23T15:35:07Z

packages/form-js-editor/src/features/properties-panel/entries/HeadersSourceSelectEntry.js

+ switch (value) {
+ case OPTIONS.static.value:
+ editField(field, {
+ columnsExpression: undefined,


For values we have a modeling behavior that removes the other properties. The advantage of that approach is that it also does the clean ups when using the modeling API directly, and not only in the properties panel entry. It's also pluggable as an extension can simply remove that behavior (for whatever reason).

Wdyt, should we do the same for columnsExpression and columns or only once it becomes more complex with more possibilities do define the source?

Yeah, I was waiting for you to raise this topic. I'll take a look into this tomorrow

@pinussilvestrus Should be done now

Thanks for the follow up, looks good to me 👍

packages/form-js-editor/src/features/properties-panel/groups/TableHeaderGroups.js

Skaiir · 2023-11-24T08:07:19Z

Had a look over, agreeing with Niklas's points but that's about all I saw at a glance. Will have a serious long review on the complete PR.

* chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

* feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

packages/form-js-editor/test/spec/features/modeling/behavior/ColumnsSourceBehavior.spec.js

Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

* chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * chore: Remove commented code * feat: Add table entries to properties panel * fix: Fix tooltip Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * chore: Rename id * feat: Use behavior to manage column headers * chore: Fix test description Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

* chore: update dependency lerna to v8 (#914) * chore: update dependency lerna to v8 * deps: remove legacy lerna scripts Cf. https://lerna.js.org/docs/legacy-package-management --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> Co-authored-by: Vinícius Goulart <vinicius.goulart@camunda.com> * chore(CI): updated snapshots [skip ci] * deps: update dependency didi to v10 (#909) * deps: update dependency didi to v10 * chore: Bump to didi@10.0.1 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vinicius Goulart <vinicius.goulart@camunda.com> * chore(CI): updated snapshots [skip ci] * chore: Bump to diagram-js@13.0.0 (#927) * deps: update dependency feelin to v3 (#941) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * chore: Fix typos in comments * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * feat: Add table entries to properties panel (#912) * chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * chore: Remove commented code * feat: Add table entries to properties panel * fix: Fix tooltip Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * chore: Rename id * feat: Use behavior to manage column headers * chore: Fix test description Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> * feat: Add table component to viewer (#920) * feat: Add table component to viewer * fix: Fix default rowCount * feat: Add generic data on editor view * fix: Refactor form field table styles * test: Add tests * fix: Turn data source into FEEL only * chore: Remove unnecessary new line * chore: Remove FEEL check on dataSource * chore: Sort by asc first * chore: Remove unnecessary label check * chore: Use const instead of let * fix: Create EditorTable * chore: Fix formatting * chore: Make label id optional * fix: Add row gap * fix: Add missing leftovers from table component (#938) * feat: Add Carbon compatibility styles (#937) * feat: Add Carbon compatibility styles * test: Add Carbon tests * feat: Add dynamic lists component (#808) * chore: rename expression-language folder * wip: implemented protoype repeatRenderManager * feat: `subform` component * feat: integrated prototype repeatRenderModule * feat: hooked up indexing to update cycle Related to #796 * feat: subform properties panel configuration Related to #796 * feat: added group styles to subform * feat: form initializer works with repeatable Related to #796 * chore: display key and path from config Related to #796 * feat: enforce path for repeatable groups Related to #796 * feat: adjusted getSubmitData for repeatable Related to #796 * feat: repeat render manager Closes #796 * chore: renamed subform to dynamic list Related to #796 * chore: adjusted path tooltip for repeating Related to #796 * feat: repeated element validation Related to #796 * wip: custom editor list renderer (missing icon) Related to #796 * wip: collapse / expand dynamic lists Related to #796 * feat: implement group/list alignment Related to #796 * chore: added empty states to group and list Related to #796 * feat: brought in new icons and matched visuals Related to #796 * fix: form root outline never shows * fix: editor no longer refreshes on element hover Closes #807 Related to #796 * feat: add/remove items in dynamic lists Related to #796 * feat: local expression contexts Related to #796 * feat: add/remove styles Related to #796 * feat: automatically scroll when adding item Related to #796 * feat: refine add/remove UX Related to #796 * chore: use karma-spec reporter for tests * chore: refactored viewer and editor tests Related to #808 * chore: large rebase test cleanups Related to #808 * fix(submit): only modify error object when needed Related to #808 * fix: final repeated subforms test adjustments Related to #808 * chore: fixed minor tabs and naming issues Related to #808 * feat: added carbon styles for dynamic list Related to #907 * fix: improved dynamic list button outlines Related to #808 * chore: rebase changes on `develop` * chore: reduced nesting and improved docs in Form.js core functions Related to #808 * chore: removed pointless useMemo Related to #808 * chore: cleanup remnants of ai generation Related to #808 * chore: switch from hardcoded to computed componentCount test Related to #808 * fix(performance): centralize variable filtering Related to https://github.com/camunda/tasklist/issues/3758 * chore: optimize svgs Related to #808 * feat: implemented proper path management for repeatable fields Related to #808 * fix: always expand when uncollapsible Related to #808 * fix: proper key change handling and repeatable filtering Related to #808 * feat: implement proper variable hiding within repeated field Related to #808 * chore: adjust table/iframe tests following rebase Related to #808 * fix: adjust numerical configs of dynamic list to prevent crashes Related to #808 * fix: properly split path replacements in pathEntry Related to #808 * fix: ensure dynamic list buttons don't submit Related to #808 * feat: Carbonise dynamic list * fix: show proper default uncollapsed items in propspan Related to #808 * feat(schema): added dynamic list component Related to #808 * chore(schema): adjust test indexes Related to #808 --------- Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> Co-authored-by: Vinicius Goulart <vinicius.goulart@camunda.com> * chore: update actions/setup-node digest to 7247617 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com> Co-authored-by: Vinícius Goulart <vinicius.goulart@camunda.com> Co-authored-by: bpmn-io-bot <bpmnio@camunda.com> Co-authored-by: Valentin Serra <valentin.serra@camunda.com>

vsgoulart requested review from pinussilvestrus and Skaiir November 23, 2023 15:13

bpmn-io-tasks bot added the needs review Review pending label Nov 23, 2023

bpmn-io-tasks bot assigned vsgoulart Nov 23, 2023

pinussilvestrus added the deploy-preview label Nov 23, 2023

github-actions bot temporarily deployed to demo-890-table-properties November 23, 2023 15:22 Destroyed

vsgoulart commented Nov 23, 2023

View reviewed changes

packages/form-js-editor/src/features/properties-panel/entries/TextEntry.js Show resolved Hide resolved

vsgoulart commented Nov 23, 2023

View reviewed changes

pinussilvestrus reviewed Nov 23, 2023

View reviewed changes

github-actions bot temporarily deployed to demo-890-table-properties November 23, 2023 15:43 Destroyed

vsgoulart force-pushed the 888-table-component branch from 6ae8f51 to 56cfdc4 Compare November 24, 2023 16:18

vsgoulart and others added 5 commits November 24, 2023 18:23

chore: Remove commented code

999e5d3

feat: Add table entries to properties panel

9c97bec

fix: Fix tooltip

f1c0a2d

Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

vsgoulart force-pushed the 890-table-properties branch from 1c73dc3 to f1c0a2d Compare November 24, 2023 16:35

github-actions bot temporarily deployed to demo-890-table-properties November 24, 2023 16:35 Destroyed

chore: Rename id

9102737

github-actions bot temporarily deployed to demo-890-table-properties November 24, 2023 16:39 Destroyed

feat: Use behavior to manage column headers

d87abc1

github-actions bot temporarily deployed to demo-890-table-properties November 24, 2023 17:47 Destroyed

vsgoulart requested a review from pinussilvestrus November 24, 2023 17:47

marcosgvieira mentioned this pull request Nov 27, 2023

Create properties panels for the table component #890

Closed

6 tasks

pinussilvestrus approved these changes Nov 28, 2023

View reviewed changes

packages/form-js-editor/test/spec/features/modeling/behavior/ColumnsSourceBehavior.spec.js Outdated Show resolved Hide resolved

chore: Fix test description

d463653

Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>

github-actions bot temporarily deployed to demo-890-table-properties November 28, 2023 12:04 Destroyed

vsgoulart merged commit ec33b55 into 888-table-component Nov 29, 2023
10 of 11 checks passed

vsgoulart deleted the 890-table-properties branch November 29, 2023 13:16

bpmn-io-tasks bot removed the needs review Review pending label Nov 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add table entries to properties panel #912

feat: Add table entries to properties panel #912

vsgoulart commented Nov 23, 2023

vsgoulart Nov 23, 2023

pinussilvestrus Nov 23, 2023

vsgoulart Nov 23, 2023

vsgoulart Nov 24, 2023

pinussilvestrus Nov 28, 2023

Skaiir commented Nov 24, 2023

feat: Add table entries to properties panel #912

feat: Add table entries to properties panel #912

Conversation

vsgoulart commented Nov 23, 2023

vsgoulart Nov 23, 2023

Choose a reason for hiding this comment

pinussilvestrus Nov 23, 2023

Choose a reason for hiding this comment

vsgoulart Nov 23, 2023

Choose a reason for hiding this comment

vsgoulart Nov 24, 2023

Choose a reason for hiding this comment

pinussilvestrus Nov 28, 2023

Choose a reason for hiding this comment

Skaiir commented Nov 24, 2023