feat: add version tag support #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
force-pushed
the
version-tag
branch
from
e68d4ad
to
50da132
Compare
|
Can someone enlighten me as to what is happening with the tests? I don't know what the issue is. |
|
@philippfromme It should be fixed now. You were asserting over the wrong attribute. The only test failing an integration test we need to fix from the Tasklist side, which is not related to this PR |
Co-authored-by: Vinicius Goulart <vinicius.goulart@camunda.com> Related to camunda/camunda-modeler#4463
philippfromme
force-pushed
the
version-tag
branch
from
876cbe0
to
43ab544
Compare
bpmn-io-tasks
bot
added
needs review
Thanks! Ready for review. |
vsgoulart
approved these changes
Aug 23, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#4463
form-jselement or visually changes an existing component.