v2: bootstrap viewer render project #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaiir
changed the title
Skaiir
changed the title
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@bpmn-io/form-js-viewer-core", | |||
| "version": "1.8.6", | |||
| "description": "View forms - powered by bpmn.io", | |||
| "description": "Manage form state - powered by bpmn.io", | |||
There was a problem hiding this comment.
We'll probably need to discuss what should go here but what is here just now is fine.
douglasbouttell-camunda
approved these changes
May 7, 2024
vsgoulart
reviewed
May 7, 2024
Comment on lines
36
to
37
| "@preact/preset-vite": "^2.8.2", | ||
| "vitest": "^1.5.3" |
There was a problem hiding this comment.
@Skaiir We can install this on the project root since we don't need them to run as a peer dependency this way we avoid users installing these packages when the user installs @bpmn-io/form-js-viewer-render
This will also make it easier for updating the packages in the future
Related to #1166
Skaiir
force-pushed
the
v2-bootstrap-viewer-render
branch
from
f74528f
to
4fe7657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1166