Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve TemplateFragment icons #6344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisrueger
Copy link
Contributor

  • show green icon for bndtools org (ours) or 3rd-party with a specific commit SHA
-workspace-templates \
    bndtools/workspace-templates/gradle; \
        name=gradle; \
        description="Setup gradle build for bnd workspace", \
    bndtools/workspace-templates/maven; \
        name=maven; \
        description="Use the maven directory layout for sources and binaries", \
    bndtools/workspace-templates/osgi; \
        name=osgi; \
        description="OSGi R8 with Felix distribution", \
    mnlipp/de.mnl.osgi/de.mnl.osgi.bnd.repository/workspace-template#b96e0a8877bad1c68cdc050d5854829253ef63bb; \
        name=IndexedMavenRepository; \
        description="Provide an OSGi repository derived from a subset of one or more maven repositories"

would show all green (notice the commit SHA at the end of the last entry):

image

  • show greyish icon for 3rdParty template fragments not pointing to a specific commit SHA... e.g. master branch. This basically means: we verified it when PR was added, but it could change in the future by the author.
-workspace-templates \
    bndtools/workspace-templates/gradle; \
        name=gradle; \
        description="Setup gradle build for bnd workspace", \
    bndtools/workspace-templates/maven; \
        name=maven; \
        description="Use the maven directory layout for sources and binaries", \
    bndtools/workspace-templates/osgi; \
        name=osgi; \
        description="OSGi R8 with Felix distribution", \
    mnlipp/de.mnl.osgi/de.mnl.osgi.bnd.repository/workspace-template; \
        name=IndexedMavenRepository; \
        description="Provide an OSGi repository derived from a subset of one or more maven repositories"

This would show the last entry with a grey icon, because it is 3rd-party (not bndtools org) and does not point to a specific commit SHA.

image

@pkriens as discussed today

- show green icon for bndtools org (ours) or 3rd-party with a specific commit SHA
- show greyish icon for everything else (means 3rdParty but no Commit SHA... e.g. master branch, which means we verified it when PR was added, but it could change in the future by the author)

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant