Remove imports of exports without a version range #6270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6267
imports (coming from exports) should not be added if the export does not specify a version, because it would lead to imports without a version-range. this could cause resolver problems because the resolver then has no version constrains and too many wiring options.
Testcases
The existing testcase
BuilderTest#testNoImportForUsedExport_971
needed adjustment.According to #6267 (comment) it does also not comply with the spec in its previous form.
Here is what has changed:
BEFORE this PR
testNoImportForUsedExport_971
AFTER this PR
testNoImportForUsedExport_971 was adjusted
Additionally I have added another test which basically is like
testNoImportForUsedExport_971
before this PR, but this testcase now shows that the imports are not added when the exports don't have a version.testEnsureNoImportForUsedExport_971_WithMissingExportVersion