-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement check to prevent infinite loop cases #43
Open
jonodrew
wants to merge
9
commits into
bmc:master
Choose a base branch
from
jonodrew:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 5, 2021
-
Implement check to prevent infinite loop cases
This code introduces a check to prevent infinite loop cases. In the test case added in 'test_unsolvable', the software looped infinitely rather than raising an error. I tested this and found that the error was occurring after the cost_matrix had been padded.
Configuration menu - View commit details
-
Copy full SHA for c8508c4 - Browse repository at this point
Copy the full SHA c8508c4View commit details
Commits on Sep 6, 2021
-
An infinite loop occurs where all remaining uncovered values are DISALLOWED. This identifies the case and raises an UnsolvableMatrix exception. I have not written a test for this as my current reproducable example is a 500 by 400 matrix.
Configuration menu - View commit details
-
Copy full SHA for 6223b5f - Browse repository at this point
Copy the full SHA 6223b5fView commit details
Commits on Feb 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6fa5278 - Browse repository at this point
Copy the full SHA 6fa5278View commit details
Commits on Feb 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7974999 - Browse repository at this point
Copy the full SHA 7974999View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ed12c - Browse repository at this point
Copy the full SHA 03ed12cView commit details -
Configuration menu - View commit details
-
Copy full SHA for abd29e2 - Browse repository at this point
Copy the full SHA abd29e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0f6af9 - Browse repository at this point
Copy the full SHA a0f6af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54b37e6 - Browse repository at this point
Copy the full SHA 54b37e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68b7391 - Browse repository at this point
Copy the full SHA 68b7391View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.