A lot of hit object render improvements & additions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Approach circle uses slightly different fading time
This reverts commit afca63f.
This change should fix the case where almost all triangles spawn outside of the circle or close to the edges. Triangle values are also mapped to the limits, which will reduce the number of identical values. The code that was responsible for moving the triangles when passing a distance equal to their size was removed, as this caused random teleportation of the triangles during the explosion.
kionell
changed the title
|
I also wanted to randomize alpha of triangles a little bit, but I don't know how to do it. Triangles are using the same shader (white texture), which makes it impossible to give its own alpha value for each particle. |
|
Currently if you stack too many triangles on top of each other, the number glow texture will become too bright. |
|
@kionell Randomizing the alpha is not possible with the current setup, as all of the triangles are rendered as a single "instance". The two solutions I see are using a custom shader+attribute, or rendering each triangle as a separate instance (probably bypassing the batch render). Unfortunately, I have a lot going on right now, so I probably won't get a chance to look through your PR for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't even know where to start lmao. I put a lot of effort into it and it still needs some minor fixes.
Most notable changes:
Cloudflare deployment to test it:
https://3f12a5fd.kionell-osu-js.pages.dev/
Here is the final result:
https://streamable.com/whzzm5