Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings seen in gcc 14.2.1 #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compiler warnings seen in gcc 14.2.1 #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pystack/_pystack/elf_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class CoreFileAnalyzer : public Analyzer
std::string locateLibrary(const std::string& lib) const;

// Destructors
~CoreFileAnalyzer();
virtual ~CoreFileAnalyzer();

// Data members
dwfl_unique_ptr d_dwfl;
Expand All @@ -84,6 +84,9 @@ class ProcessAnalyzer : public Analyzer
// Constructors
explicit ProcessAnalyzer(pid_t pid);

// Destructors
virtual ~ProcessAnalyzer() = default;

// Methods
const dwfl_unique_ptr& getDwfl() const override;

Expand Down
6 changes: 6 additions & 0 deletions src/pystack/_pystack/process.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ class ProcessManager : public AbstractProcessManager
std::vector<VirtualMap> memory_maps,
MemoryMapInformation map_info);

// Destructors
virtual ~ProcessManager() = default;

// Getters
const std::vector<int>& Tids() const override;

Expand All @@ -169,6 +172,9 @@ class CoreFileProcessManager : public AbstractProcessManager
std::vector<VirtualMap> memory_maps,
MemoryMapInformation map_info);

// Destructors
virtual ~CoreFileProcessManager() = default;

// Getters
const std::vector<int>& Tids() const override;

Expand Down
2 changes: 0 additions & 2 deletions src/pystack/_pystack/pyframe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
#include "pytypes.h"
#include "version.h"

static constexpr int FRAME_LIMIT = 4096;

namespace pystack {
FrameObject::FrameObject(
const std::shared_ptr<const AbstractProcessManager>& manager,
Expand Down
1 change: 0 additions & 1 deletion src/pystack/_pystack/pytypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,6 @@ GenericObject::toString(ssize_t max_size) const
}

NoneObject::NoneObject(remote_addr_t addr)
: d_addr(addr)
{
}

Expand Down
3 changes: 0 additions & 3 deletions src/pystack/_pystack/pytypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,6 @@ class NoneObject

// Methods
std::string toString(ssize_t max_size) const;

private:
remote_addr_t d_addr;
};

class Object
Expand Down
Loading
Loading