Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-61890 - Introducing config for zap layer #2066

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Thejas-bhat
Copy link
Member

@Thejas-bhat Thejas-bhat commented Aug 29, 2024

  • Currently there isn't a concept of config at the zap layer and whatever storage level configurations present (at various points of index lifetime) are global variables. This forces all indexes' segments to use same values irrespective of how heavy indexes are.
  • The PR introduces segmentConfig that can be used to pass index specific config values for the zap level. This would help in the future to perform any index specific tuning at the zap level.
  • This involves extending the existing interface's Open and New APIs.
  • The segmentConfig is something that's constructed by parsing the scorch.config and persisted in the index_meta.json file.

@Thejas-bhat Thejas-bhat marked this pull request as ready for review August 29, 2024 14:50
@metonymic-smokey metonymic-smokey changed the title Introducing config for zap layer MB-61890 - Introducing config for zap layer Sep 5, 2024
@abhinavdangeti abhinavdangeti added this to the v2.5.0 milestone Sep 5, 2024
@abhinavdangeti abhinavdangeti removed the request for review from moshaad7 October 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants