MB-61889: support search with params #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshaad7
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
search_knn.go
Outdated
| // | ||
| // For Faiss IVF index, supported search params are: | ||
| // - nprobe_pct : int // percentage of total clusters to search | ||
| // - max_codes_pct : float // percentage of total vectors to visit to do a query (across all clusters) |
There was a problem hiding this comment.
@moshaad7 Given that these are going to be applicable to IVF indexes only, should we force their names to indicate this as well - ivf_nprobe_pct & ivf_max_codes_pct.
abhinavdangeti
requested changes
Jul 18, 2024
- update knn search request syntax, to enable users to supply search-time parameters, using which they can control the latency v/s recall tradeoff. - Supported parameters are + ivf_nprobe_pct + ivf_max_codes_pct - These parameters will be applied to those segments which have faissIVFIndex - In future, to support other faiss Index classes (like hnsw), the list of supported knn search params can be extended.
* 65187de Mohd Shaad Khan | MB-61889: support search with params
abhinavdangeti
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update knn search request syntax, to enable users to supply search-time parameters,
using which they can control the latency v/s recall tradeoff.
Supported parameters are
These parameters will be applied to those segments which have faissIVFIndex
In future, to support other faiss Index classes (like hnsw), the list of
supported knn search params can be extended.