Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Flexible, Generic WebSocket Sessions #115

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Sep 4, 2024

Removed

  • nakago-ws - Removed Session in favor of a generic type parameter for the Connections struct.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.13%. Comparing base (1c755ea) to head (8b7f4d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nakago_ws/src/controller.rs 0.00% 7 Missing ⚠️
nakago_ws/src/connections.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   62.19%   62.13%   -0.06%     
==========================================
  Files          47       47              
  Lines        3211     3201      -10     
==========================================
- Hits         1997     1989       -8     
+ Misses       1214     1212       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkonkle bkonkle merged commit 10b39ac into main Sep 4, 2024
4 of 5 checks passed
@bkonkle bkonkle deleted the features/flexible-ws-session branch September 4, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant