Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS error when computing tab wrapping. #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix JS error when computing tab wrapping. #69

wants to merge 3 commits into from

Conversation

bedney
Copy link

@bedney bedney commented Oct 6, 2014

When computing tab wrapping behavior, these check expressions will error at the boundary (when i is 0 or is at the last index). This patch checks i at these boundaries before it performs the other check.

@matthewp
Copy link
Contributor

matthewp commented Oct 6, 2014

Awesome! Can you include a test?

@bedney
Copy link
Author

bedney commented Oct 6, 2014

So that's fine, but I'm having trouble running the unit tests. I tried 'npm test' and phantomjs was hanging, so I switched testee's target browser to chrome and I noticed that I'm getting errors in the index.html page about not being able to find QUnit resources. Any suggestions?

@matthewp
Copy link
Contributor

matthewp commented Oct 6, 2014

did you run npm install and bower install? Try testing from a local browser first.

@bedney
Copy link
Author

bedney commented Oct 6, 2014

Ok, got the tests running and updated the forward tabbing test to show wrap behavior. The reverse tabbing test was already showing wraparound... which is interesting since it must've been passing. In any case, feel free to look at this and let me know. This is my first time committing to this codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants