Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement io.Reader #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement io.Reader #52

wants to merge 2 commits into from

Commits on Apr 21, 2016

  1. Implemented io.Reader interface 

    Pretty much as implemented in bytes.Read() [1]

[1]: https://golang.org/src/bytes/reader.go?s=3260:3292#L38
    @xoen
    xoen committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    f16807b View commit details
    Browse the repository at this point in the history

  2. Reset reader pointer when the JSON data changes 

    As the reader pointer contains the bytes for the JSON, whne it changes these
would not be valid anymore.

NOTE: If the JSON changes between 2 Read() calls the result would still be
      incorrect as the 2nd read would returns bytes from the new JSON.
      Not sure how this
    @xoen
    xoen committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    d16666b View commit details
    Browse the repository at this point in the history