Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library, Step 1 #10

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Library, Step 1 #10

merged 1 commit into from
Feb 5, 2024

Conversation

Wohlstand
Copy link
Contributor

@Wohlstand Wohlstand commented Feb 5, 2024

This is a small commit where I fixed the QMake build on Windows.

As we discussed here, I will send you a sequence of pull-requests based on my library-3 branch. I will send the next once you merge this. And then, continue this until all commits from the library-3 will reach you.

@bisqwit
Copy link
Owner

bisqwit commented Feb 5, 2024

What is the reason for changing from C++11 to C++17 in the commit?

@Wohlstand
Copy link
Contributor Author

What is the reason for changing from C++11 to C++17 in the commit?

I don't remind why I did that, but as I remind, I got some errors/warnings when I built this on Windows. I should try to check this again and tell what is a reason of this failure...

@Wohlstand
Copy link
Contributor Author

Or wait... I remind that you specified in your Makefile the c++1y, and I though it was C++17, but it was actually C++14. But, I'll test the build on my end first, and then I'll tweak this case.

@Wohlstand
Copy link
Contributor Author

Okay, I see, the C++17 is required because of the std::string_veiw being used by you in the code. With C++14 the build fails. The std::string_view is a part of C++17 standard: https://en.cppreference.com/w/cpp/header/string_view

@bisqwit bisqwit merged commit eded08f into bisqwit:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants