This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Improvement in split_libraries_lea_seq.py #1883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raise NoConsensusSeqsError when there is no consensus
stress testing to make sure errors are meaningful when the optional arguments are not as expected
|
Thanks @charudatta-navare! Can you please revert back to using the deprecated |
|
Thanks for letting me know - I will make the changes tomorrow. |
|
Thanks! |
|
Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1540/ |
|
Made the changes, @cleme @jairideout. Have a look! |
|
Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1541/ |
|
Thanks! There are merge conflicts, can you please fix? |
|
Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1547/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed deprecated function parse_fastq, and changed it to skbio.io.read
made sure meaningful errors are given when unexpected optional arguments are supplied