Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Improvement in split_libraries_lea_seq.py #1883

Closed
wants to merge 7 commits into from
Closed

Improvement in split_libraries_lea_seq.py #1883

wants to merge 7 commits into from

Conversation

charudatta-navare
Copy link
Contributor

removed deprecated function parse_fastq, and changed it to skbio.io.read
made sure meaningful errors are given when unexpected optional arguments are supplied

raise NoConsensusSeqsError when there is no consensus
stress testing to make sure errors are meaningful when the optional
arguments are not as expected
@jairideout jairideout added this to the QIIME 1.9.0 milestone Jan 17, 2015
@jairideout
Copy link
Member

Thanks @charudatta-navare! Can you please revert back to using the deprecated parse_fasta/parse_fastq parsers? See @gregcaporaso's comment here for why we'd like to keep using the old parsers for 1.9.0.

@jairideout jairideout self-assigned this Jan 17, 2015
@charudatta-navare
Copy link
Contributor Author

Thanks for letting me know - I will make the changes tomorrow.
@jairideout

@jairideout
Copy link
Member

Thanks!

@ghost
Copy link

ghost commented Jan 17, 2015

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1540/

@charudatta-navare
Copy link
Contributor Author

Made the changes, @cleme @jairideout. Have a look!

@ghost
Copy link

ghost commented Jan 18, 2015

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1541/

@jairideout
Copy link
Member

Thanks! There are merge conflicts, can you please fix?

@ghost
Copy link

ghost commented Jan 21, 2015

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1547/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants