Fix TypeError on null path variable #2966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify event filter uses in hx-trigger
* Change hx-trigger event filter example to avoid ambiguity
input is both a tag and an event.
* Document the scope difference between standard selector and event filter
from:input listens to the page and click[event.target.matches('input')] listens to the element.
* Document that event filters as an alternative to CSS selectors require eval
* Move note about eval to standard event filters section.
* Simplify the referenced to standard event filters in the standard event modifiers section, and link to the standard event filters section instead.
* End quote in the correct place in standard event modifier doc.
* Correct language on how event filters from:body receive events.
* hx-trigger filter example catches click events specifically.
Add htmx4s to scala examples
Telroshan
approved these changes
Oct 15, 2024
|
Bruh this online-retarget never seems to work as it should |
My bad, done :) |
|
Seems you'll want to rebase @youssame as the PR now brings a few unrelated commits in, making the diff harder to review |
|
I just created a new PR #2967 that will be easier I will close this one |
|
=> #2967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I check if the
pathis null or empty when the user hasn't set the action property or has left it empty.Corresponding issue: #2963
Testing
I added two tests that check if everything is OK in two cases (action is unset or is empty)
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded