Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump-up CometBFT to v0.37.2 #4

Open
wants to merge 19 commits into
base: release/v0.37.2-bianjie
Choose a base branch
from

Conversation

taramakage
Copy link


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

mergify bot and others added 19 commits April 27, 2023 14:22
* Fix `TestStateOversizedBlock` (cometbft#755)

* Fix TestStateOversizedBlock

* Moved `findBlockSizeLimit` together with other aux functions

(cherry picked from commit c58597d)

# Conflicts:
#	consensus/state_test.go

* Revert "Fix `TestStateOversizedBlock` (cometbft#755)"

This reverts commit 50a4555.

* Fix `TestStateOversizedBlock` (cometbft#755)

* Fix TestStateOversizedBlock

* Moved `findBlockSizeLimit` together with other aux functions

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
Replaced int64 with big.int

Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit ecd5ee1)

Co-authored-by: Sergio Mena <sergio@informal.systems>
* Unsafe int cast in `kill` command (cometbft#783)

* Unsafe int cast in `kill` command

* Revert "Unsafe int cast in `kill` command"

This reverts commit bbd649b.

* Changed strategy

(cherry picked from commit 03c5e77)

# Conflicts:
#	cmd/cometbft/commands/debug/kill.go

* Revert "Unsafe int cast in `kill` command (cometbft#783)"

This reverts commit 5cf3226.

* Unsafe int cast in `kill` command (cometbft#783)

* Unsafe int cast in `kill` command

* Revert "Unsafe int cast in `kill` command"

This reverts commit bbd649b.

* Changed strategy

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
…metbft#814)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.17.0 to 1.18.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.17.0...v1.18.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ometbft#866)

Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases)
- [Commits](slackapi/slack-github-action@v1.23.0...v1.24.0)

---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#867)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.18.0 to 1.19.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.18.0...v1.19.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
…metbft#911)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.19.0 to 1.20.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.19.0...v1.20.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cometbft#890) (cometbft#926)

* add a test to trigger the issue
* add a fix (in particular, we track the sender when receiving a tx twice)
* add a changelog

---------

Co-authored-by: Daniel <daniel.cason@informal.systems>
(cherry picked from commit a09f5d3)

* update fix and test wrt. v0.37.x

---------

Co-authored-by: Pierre Sutra <0track@gmail.com>
* Generate prometheus yaml on setup

* change file extension

* move template to file

* add templates dir

(cherry picked from commit 3701c9f)

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
…ometbft#965)

* Add requirement for `CheckTx` in ABCI spec (cometbft#928)

* Add requirement for `CheckTx` in ABCI spec

* Apply suggestions from code review

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>

* Added sentence from @jmalicevic's suggestion

* Addressed review comments

* Update spec/abci/abci++_app_requirements.md

Co-authored-by: Daniel <daniel.cason@informal.systems>

* Addressed comment

* `CheckTx` requirements for the app, new version

* New version of `CheckTx` requirement, after yesterday's discussion

* Update spec/abci/abci++_app_requirements.md

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>

* Addressed @josef-widder's comment

---------

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Co-authored-by: Daniel <daniel.cason@informal.systems>
(cherry picked from commit 21e94a2)

# Conflicts:
#	spec/abci/abci++_app_requirements.md

* Revert "Add requirement for `CheckTx` in ABCI spec (cometbft#928)"

* Add requirement for `CheckTx` in ABCI spec (cometbft#928)

* Add requirement for `CheckTx` in ABCI spec

* Apply suggestions from code review

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>

* Added sentence from @jmalicevic's suggestion

* Addressed review comments

* Update spec/abci/abci++_app_requirements.md

Co-authored-by: Daniel <daniel.cason@informal.systems>

* Addressed comment

* `CheckTx` requirements for the app, new version

* New version of `CheckTx` requirement, after yesterday's discussion

* Update spec/abci/abci++_app_requirements.md

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>

* Addressed @josef-widder's comment

---------

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Co-authored-by: Daniel <daniel.cason@informal.systems>

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Co-authored-by: Daniel <daniel.cason@informal.systems>
…ometbft#865) (cometbft#969)

* avoid recursive call after rename to (*PeerState).MarshalJSON

* add test

* add change doc

* explain for nolint

* fix lint

* fix golangci-lint to v1.52.2

* fix golangci-lint to v1.52.2

* Revert "fix golangci-lint to v1.52.2"

This reverts commit 598a9ef.

* Revert "fix golangci-lint to v1.52.2"

This reverts commit a8aad12.

* Reintroduced `cmtjson`

* Avoid copying Mutex

* Avoid copying Mutex -- 2nd try, more succint

* Update .changelog/unreleased/bug-fixes/865-fix-peerstate-marshaljson.md

* Update consensus/reactor_test.go

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit f6ea091)

Co-authored-by: mmsqe <mavis@crypto.com>
* changelog: Clean up and reorder

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Add severity to security fixes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Add missing entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Release v0.37.2

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Rebuild changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* version: Bump to v0.37.2

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* test/e2e: Use Debian Bullseye as base image

Golang recently started offering Debian Bookworm as the default distro
for `golang:1.20`, which provides a newer version of RocksDB than what
we support in cometbft-db.

For now this pins the image to Bullseye, which is the base image we have
been using for some time now.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants