Cesse de lancer npm test
dans la tâche de build
#1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite à des recherches de @bbougon nous comprenons que lancer les
tests
dans notre step debuild
pourrait induire l'installation desdevDependencies
(car elles sont nécessaires aux tests) chez Scalingo… ou bien induire la non-suppression de celles-ci.On choisit de ne plus lancer les tests au moment du
build
puisqu'ils sont déjà exécutés par la CI.Cela nous permet :
devDependencies
persistées chez Scalingo : donc la taille de notre image est réduite.Pour être totalement sans
devDeps
, on peut utiliserNPM_CONFIG_PRODUCTION=true
comme variable d'environnement Scalingo.Mais alors c'est
husky
qui crash car il est non trouvé.Et on garde un oeil sur cette issue chez Scalingo