just disable the damn thing

benjamin-hodgson · Nov 16, 2023 · 9084d5b · 9084d5b
1 parent 7dc09a9
commit 9084d5b
Show file tree

Hide file tree

Showing 26 changed files with 48 additions and 10 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -8,10 +8,5 @@ tab_width = 4
 end_of_line = lf
 insert_final_newline = true
 
-[*.cs]
-# seemingly a bug in `dotnet format`
-dotnet_sort_system_directives_first = false
-dotnet_separate_import_directive_groups = false
-
 [*.Generated.cs]
 generated_code = true
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -15,6 +15,8 @@ jobs:
     uses: benjamin-hodgson/BuildScripts/.github/workflows/dotnet.yml@main
     with:
       DOCS_FOLDER: Pidgin.Docs
+      # due to a bug in `dotnet format` with `using static`
+      CHECK_FORMATTING: false
       NET8: true
     secrets:
       NUGET_KEY: ${{ secrets.NUGET_KEY }}
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -13,7 +13,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <GlobalPackageReference Include="Benjamin.Pizza.BuildScripts" Version="2.2.4" />
+        <GlobalPackageReference Include="Benjamin.Pizza.BuildScripts" Version="2.2.2" />
         <GlobalPackageReference Include="StyleCop.Analyzers" Version="1.1.118" />
     </ItemGroup>
 

diff --git a/Pidgin.Bench/ExpressionBench.cs b/Pidgin.Bench/ExpressionBench.cs
@@ -1,9 +1,12 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Configs;
+
 using Pidgin.Expression;
+
 using static Pidgin.Parser<char>;
 
 namespace Pidgin.Bench;

diff --git a/Pidgin.Bench/JsonBench.cs b/Pidgin.Bench/JsonBench.cs
@@ -3,8 +3,10 @@
 using System.Collections.Immutable;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Configs;
+
 using Pidgin.Bench.SpracheParsers;
 using Pidgin.Bench.SuperpowerParsers;
 using Pidgin.Examples.Json;

diff --git a/Pidgin.Bench/NumberBench.cs b/Pidgin.Bench/NumberBench.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
+
 using BenchmarkDotNet.Attributes;
 
 namespace Pidgin.Bench;

diff --git a/Pidgin.Bench/SpracheParsers/SpracheJsonParser.cs b/Pidgin.Bench/SpracheParsers/SpracheJsonParser.cs
@@ -1,7 +1,10 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
+
 using Pidgin.Examples.Json;
+
 using Sprache;
+
 using static Sprache.Parse;
 
 namespace Pidgin.Bench.SpracheParsers;

diff --git a/Pidgin.Bench/StringBench.cs b/Pidgin.Bench/StringBench.cs
@@ -1,4 +1,5 @@
 using System.Diagnostics.CodeAnalysis;
+
 using BenchmarkDotNet.Attributes;
 
 namespace Pidgin.Bench;

diff --git a/Pidgin.Bench/SuperpowerParsers/SuperpowerJsonParser.cs b/Pidgin.Bench/SuperpowerParsers/SuperpowerJsonParser.cs
@@ -1,6 +1,8 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
+
 using Pidgin.Examples.Json;
+
 using Superpower;
 using Superpower.Parsers;
 

diff --git a/Pidgin.Examples/Expression/ExprParser.cs b/Pidgin.Examples/Expression/ExprParser.cs
@@ -1,6 +1,8 @@
 using System;
 using System.Collections.Immutable;
+
 using Pidgin.Expression;
+
 using static Pidgin.Parser;
 
 namespace Pidgin.Examples.Expression;

diff --git a/Pidgin.Examples/Json/JsonParser.cs b/Pidgin.Examples/Json/JsonParser.cs
@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
+
 using static Pidgin.Parser;
 using static Pidgin.Parser<char>;
 

diff --git a/Pidgin.Examples/Xml/XmlParser.cs b/Pidgin.Examples/Xml/XmlParser.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+
 using static Pidgin.Parser;
 using static Pidgin.Parser<char>;
 

diff --git a/Pidgin.Tests/CommentParserTests.cs b/Pidgin.Tests/CommentParserTests.cs
@@ -1,5 +1,7 @@
 using Pidgin.Comment;
+
 using Xunit;
+
 using static Pidgin.Parser;
 using static Pidgin.Parser<char>;
 

diff --git a/Pidgin.Tests/DocumentationTests.cs b/Pidgin.Tests/DocumentationTests.cs
@@ -1,5 +1,7 @@
 using System.Threading.Tasks;
+
 using Benjamin.Pizza.DocTest;
+
 using Xunit;
 
 namespace Pidgin.Tests;

diff --git a/Pidgin.Tests/ExpressionExampleTests.cs b/Pidgin.Tests/ExpressionExampleTests.cs
@@ -1,3 +1,5 @@
+using System.Collections.Immutable;
+
 using Pidgin.Examples.Expression;
 
 using Xunit;
@@ -23,10 +25,8 @@ public void TestExpression()
                 new Call(
                     new Call(
                         new Identifier("foo"),
-                        [
-                            new UnaryOp(UnaryOperatorType.Neg, new Literal(3)),
-                            new Identifier("x")
-                        ]
+                        [new UnaryOp(UnaryOperatorType.Neg, new Literal(3)), new Identifier("x")
+]
                     ),
                     []
                 ),

diff --git a/Pidgin.Tests/ExpressionParserTests.cs b/Pidgin.Tests/ExpressionParserTests.cs
@@ -2,8 +2,11 @@
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+
 using Pidgin.Expression;
+
 using Xunit;
+
 using static Pidgin.Parser;
 using static Pidgin.Parser<char>;
 

diff --git a/Pidgin.Tests/ParseStateTests.cs b/Pidgin.Tests/ParseStateTests.cs
@@ -1,8 +1,10 @@
 using System;
 using System.IO;
 using System.Numerics;
+
 using Pidgin.Configuration;
 using Pidgin.TokenStreams;
+
 using Xunit;
 
 namespace Pidgin.Tests;

diff --git a/Pidgin.Tests/ResumableTokenStreamTests.cs b/Pidgin.Tests/ResumableTokenStreamTests.cs
@@ -1,6 +1,8 @@
 using System;
 using System.IO;
+
 using Pidgin.TokenStreams;
+
 using Xunit;
 
 namespace Pidgin.Tests;

diff --git a/Pidgin.Tests/StringParserTests.cs b/Pidgin.Tests/StringParserTests.cs
@@ -3,7 +3,9 @@
 using System.Collections.Immutable;
 using System.Linq;
 using System.Text;
+
 using Xunit;
+
 using static Pidgin.Parser;
 using static Pidgin.Parser<char>;
 
@@ -1128,6 +1130,7 @@ public void TestCIOneOf()
                         new Expected<char>(ImmutableArray.Create('B')),
                         new Expected<char>(ImmutableArray.Create('c')),
                         new Expected<char>(ImmutableArray.Create('C'))
+,
                     ],
                     0,
                     SourcePosDelta.Zero,
@@ -1157,6 +1160,7 @@ public void TestCIOneOf()
                         new Expected<char>(ImmutableArray.Create('B')),
                         new Expected<char>(ImmutableArray.Create('c')),
                         new Expected<char>(ImmutableArray.Create('C'))
+,
                     ],
                     0,
                     SourcePosDelta.Zero,

diff --git a/Pidgin.Tests/TryTests.cs b/Pidgin.Tests/TryTests.cs
@@ -214,6 +214,7 @@ [new Expected<TToken>(ImmutableArray.CreateRange(render("foobat")))],
                     [
                         new Expected<TToken>(ImmutableArray.CreateRange(render("foo"))),
                         new Expected<TToken>(ImmutableArray.CreateRange(render("foobat")))
+,
                     ],
                     0,
                     SourcePosDelta.Zero,

diff --git a/Pidgin.Tests/XmlTest.cs b/Pidgin.Tests/XmlTest.cs
@@ -1,6 +1,9 @@
 using System;
+
 using Pidgin.Examples.Xml;
+
 using Xunit;
+
 using Attribute = Pidgin.Examples.Xml.Attribute;
 
 namespace Pidgin.Tests;

diff --git a/Pidgin/ParseState.ComputeSourcePos.cs b/Pidgin/ParseState.ComputeSourcePos.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
+
 using Pidgin.Configuration;
 
 namespace Pidgin;

diff --git a/Pidgin/ParseState.cs b/Pidgin/ParseState.cs
@@ -3,6 +3,7 @@
 using System.ComponentModel;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
+
 using Pidgin.Configuration;
 
 namespace Pidgin;

diff --git a/Pidgin/Parser.Chain.cs b/Pidgin/Parser.Chain.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
+
 using Pidgin.Configuration;
 
 namespace Pidgin;

diff --git a/Pidgin/Parser.Configuration.cs b/Pidgin/Parser.Configuration.cs
@@ -1,4 +1,5 @@
 using System.Diagnostics.CodeAnalysis;
+
 using Pidgin.Configuration;
 
 namespace Pidgin;

diff --git a/Pidgin/ParserExtensions.cs b/Pidgin/ParserExtensions.cs
@@ -1,8 +1,10 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+
 using Pidgin.Configuration;
 using Pidgin.TokenStreams;
+
 using Config = Pidgin.Configuration.Configuration;
 
 namespace Pidgin;