🐛 Fix Rectangle.FromSides creation #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's this?
This PR fixes the
Rectangle.FromSidesmethod to create the correct rectangle. Right now it has the X and Y dimensions flipped.🔍 Why do we want this?
To have correctly oriented rectangles.
🏗 How is it done?
First added a test case to reproduce the bug, then fixed it. Also added some other basic test cases for similar code paths for consistency. We could be testing
Rectanglemuch more but that was not the intent of this PR.💥 Breaking changes
If people considered this a feature... they really shouldn't
🦋 Side effects
I disabled the .NET 5 tests since .NET 5 is no longer supported and it wouldn't run locally on my machine. We should probably stop supporting it altogether but I'll leave that to a separate PR.