Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bech32 prefix for Litecoin mainnet and testnet #16

Open
wants to merge 1 commit into
base: litecoin
Choose a base branch
from

Conversation

majestic84
Copy link

This PR changes the bech32 prefix from lc1 to ltc1 on mainnet, and from tb1 to tltc1 on testnet.

@@ -5,3 +5,4 @@ test.js
docker_data/
docs/
browser/bcoin*
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. It's to keep my IDE (Webstorm) state files from being tracked by git.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally went ahead and added .idea to my global ignore

@tynes
Copy link
Member

tynes commented Apr 16, 2019

@majestic84 Thanks for submitting a PR. The tests will break without updating them as well

See:
tynes/lcoin@df5c412
tynes/lcoin@6083da2

@majestic84
Copy link
Author

@majestic84 Thanks for submitting a PR. The tests will break without updating them as well

See:
tynes/lcoin@df5c412
tynes/lcoin@6083da2

Thanks @tynes I'll update those now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants