Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerfilelint to dockerfile_lint #51

Merged
merged 25 commits into from
Jun 14, 2018
Merged

dockerfilelint to dockerfile_lint #51

merged 25 commits into from
Jun 14, 2018

Conversation

suujia
Copy link
Contributor

@suujia suujia commented Jun 14, 2018 •
edited
Loading

ignore errors of sudo use and :latest tag

see #50 for more info

suujia added 24 commits May 15, 2018 09:28
@suujia
Copy link
Contributor Author

suujia commented Jun 14, 2018 •
edited
Loading

ok i see. looks like these crazy commits will follow me around 😅 my bad

unsure why the previous commits removing poretools that have already been merged is still showing up in this pull request.

@suujia suujia merged commit 72ad64d into bcgsc:master Jun 14, 2018
@sjackman
Copy link
Collaborator

I believe the committed dockerfile_rules.yaml overrides the default set of rules. I've opened an issue at projectatomic/dockerfile_lint#110 to ask how to override the severity of a default rule. In the mean time, please use dockerfile_lint -e >dockerfile_rules.yaml to export the default rules. and commit that default set of rules. Then we can modify the default set to suit our purpose.

@suujia suujia mentioned this pull request Jun 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@suujia suujia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suujia @sjackman