Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an environment alert that displays what environment is passed in (DEV, TEST, or SANDBOX) #357

Merged
merged 2 commits into from
May 22, 2024

Conversation

EPortman
Copy link
Collaborator

Issue #:
https://github.com/bcgov/entity/issues/

Description of changes:
Added an environment parameter that can be passed either 'DEV', 'TEST', or 'SANDBOX'. If one of these are passed in a banner is displayed showing the environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ozamani9gh ozamani9gh self-requested a review May 22, 2024 20:25
Copy link
Collaborator

@ozamani9gh ozamani9gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@ozamani9gh ozamani9gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ozamani9gh ozamani9gh merged commit de5f7d8 into bcgov:master May 22, 2024
6 of 9 checks passed
@seeker25
Copy link
Collaborator

Need to update the package.json and package-lock.json @EPortman that way the npm publish works

@EPortman
Copy link
Collaborator Author

My mistake. Wil update it now.

@EPortman
Copy link
Collaborator Author

I submitted another PR with the version numbers bumped

#358

@seeker25
Copy link
Collaborator

good stuff, publishing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants