Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: docker compose updates #520

Merged
merged 13 commits into from
Jul 19, 2023
Merged

feat: docker compose updates #520

merged 13 commits into from
Jul 19, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Jul 12, 2023 •
edited
Loading

Overhaul of docker-compose.yml in an effort to nag people into using it.

Run with: docker compose up

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@DerekRoberts DerekRoberts self-assigned this Jul 12, 2023
@DerekRoberts DerekRoberts added the enhancement New feature or request label Jul 12, 2023
@github-actions github-actions bot added java Pull requests that update Java code backend code related to the java backend application feature labels Jul 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

Current changelog

Features

@github-actions github-actions bot added feature and removed feature labels Jul 12, 2023
@DerekRoberts DerekRoberts temporarily deployed to dev July 12, 2023 18:09 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 12, 2023 18:09 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 12, 2023 18:09 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 12, 2023 18:12 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 12, 2023 18:15 — with GitHub Actions Inactive
paulushcgcj
paulushcgcj previously requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@paulushcgcj paulushcgcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the healthcheck params and the logging part as well, just for reference use.

I'll take care of the java part

docker-compose.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added feature and removed feature labels Jul 12, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review July 12, 2023 18:51
@github-actions github-actions bot added feature and removed feature labels Jul 12, 2023
@DerekRoberts DerekRoberts force-pushed the feat/dockerComposeUpdates branch 2 times, most recently from 70c3beb to ecaab66 Compare July 18, 2023 20:37
@github-actions github-actions bot added feature and removed feature labels Jul 18, 2023
@DerekRoberts DerekRoberts temporarily deployed to dev July 18, 2023 20:57 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 18, 2023 20:58 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 18, 2023 20:58 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Jul 18, 2023
@DerekRoberts DerekRoberts temporarily deployed to dev July 18, 2023 23:50 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 18, 2023 23:50 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Jul 18, 2023
@DerekRoberts DerekRoberts reopened this Jul 19, 2023
@github-actions github-actions bot added feature and removed feature labels Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DerekRoberts DerekRoberts temporarily deployed to dev July 19, 2023 00:21 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 19, 2023 00:22 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 19, 2023 00:22 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 19, 2023 00:23 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev July 19, 2023 00:27 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia merged commit 6858ef2 into main Jul 19, 2023
40 of 41 checks passed
@mamartinezmejia mamartinezmejia deleted the feat/dockerComposeUpdates branch July 19, 2023 04:04
This was referenced Jul 19, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@paulushcgcj paulushcgcj Awaiting requested review from paulushcgcj paulushcgcj is a code owner

Assignees

@DerekRoberts DerekRoberts

Labels
backend code related to the java backend application enhancement New feature or request feature java Pull requests that update Java code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DerekRoberts @paulushcgcj @mamartinezmejia