Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe:FSADT1-1522): Create full search (data table) #1244

Merged
merged 71 commits into from
Oct 17, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Oct 16, 2024

Description

  • Fires the search on pressing the Enter key;
  • displays the full search results on the table;
  • updates tag colors;
  • fixes display of data-table skeleton;
  • resets current page on new search (pagination);
  • fixes display/hide error message.

Note: there's been some extra-work to prevent firing the search when user is actually pressing enter to "select" an option from the autocomplete. It should not (and it won't) fire the search when Enter is pressed if an autocomplete option is focused.
There's also been some extra-work to find out how to load the tag colors from nr-theme.

Fixes FSADT1-1522

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

# Conflicts:
#	legacy/src/main/java/ca/bc/gov/app/controller/ClientSearchController.java
#	legacy/src/main/java/ca/bc/gov/app/repository/ForestClientRepository.java
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Bug Fixes

  • allow empty search (7d41d9f)
  • apply the feature flag to the Client search button (9055198)
  • display empty acronyms (28628b5)
  • fe:FSADT1-1521: clear the AutoComplete field when preventSelection is true (#1230) (13db50d)
  • fix displaying issue on status column (f4e5758)
  • prevent emitting press:enter when it's a selection (9d6a1b2)
  • prevent emitting the full css theme (c1e239f)
  • remove optional from validations (05e9848)
  • reset error message (8d4db0a)

Features

  • add css tag colors from nr-theme (128789e)
  • be:FSADT1-1519: Create API endpoint for predictive search (8ca00b1)
  • be:FSADT1-1519: Create API endpoint for predictive search (3b2941c)
  • be:FSADT1-1519: Create API endpoint for predictive search (b467da6)
  • emit press:enter (3b498ca)
  • fe:FSADT1-1521: create the predictive search (#1223) (258ed26), closes #1227
  • fe:FSADT1-1541: Display an error message when the BE is down (#1227) (7127d58)
  • FSADT1-1519: Draft for Create API endpoint for predictive search (1187889)
  • FSADT1-1519: Predictive search #2 (b4b34c3)
  • FSADT1-1519: Predictive search endpoint #1 (cc6f1b2)
  • prevent search with invalid value (a51efb1)
  • set status tag colors (f3a84ba)
  • update full search behavior (f6ece29)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants