Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use BaseComplaint usage from nrs-ce-common-types #720

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

gregorylavery
Copy link
Contributor

@gregorylavery gregorylavery commented Oct 22, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Adds a dependency on nrs-ce-common-types as a new package that will include the BaseComplaint type to be shared between the backend and frontend to standardize the objects.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run the apps using both COS and CEEB roles and confirm that the map and list view work with all the complaint types
  • Open, edit and save complaints by making changes to all fields in the data and confirm they are saved as expected.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@gregorylavery gregorylavery marked this pull request as ready for review October 23, 2024 21:30
Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New repo should be renamed to nr-compliance-enforcement-common

exported packages could stay the same name for now, but it might be good to rename this to common if the we will not be exporting multiple different packages in the future (can still be nrs-ce-common)

I think the following can be added to the common type:
status (string)
ownedBy (string)
reportedOn (date)
updatedOn (date)
complaintMethodReceivedCode (string)

These fields should be removed from our backend type as they are in the common type:
createdBy
updatedBy

These fields should be removed from our frontend type as they are in the common type:
reportedByOther
incidentDateTime

@gregorylavery
Copy link
Contributor Author

@afwilcox
Updates requested have been addressed - more fields have been moved into the common types structure and the version in use of that package has been updated to v1.0.9 to address this. The repo name for the common code has also been updated to nr-compliance-enforcement-common

Copy link

sonarcloud bot commented Oct 30, 2024

@afwilcox afwilcox merged commit 8c3d91e into release/noble-sea-lemon Oct 30, 2024
15 checks passed
@afwilcox afwilcox deleted the CE-858 branch October 30, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants