-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use BaseComplaint usage from nrs-ce-common-types #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New repo should be renamed to nr-compliance-enforcement-common
exported packages could stay the same name for now, but it might be good to rename this to common if the we will not be exporting multiple different packages in the future (can still be nrs-ce-common)
I think the following can be added to the common type:
status (string)
ownedBy (string)
reportedOn (date)
updatedOn (date)
complaintMethodReceivedCode (string)
These fields should be removed from our backend type as they are in the common type:
createdBy
updatedBy
These fields should be removed from our frontend type as they are in the common type:
reportedByOther
incidentDateTime
@afwilcox |
Quality Gate passedIssues Measures |
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Adds a dependency on nrs-ce-common-types as a new package that will include the BaseComplaint type to be shared between the backend and frontend to standardize the objects.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: