Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CE 1124 #711

Merged
merged 13 commits into from
Oct 17, 2024
Merged

fix: CE 1124 #711

merged 13 commits into from
Oct 17, 2024

Conversation

nayr974
Copy link
Contributor

@nayr974 nayr974 commented Oct 17, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@nayr974 nayr974 requested a review from jon-funk October 17, 2024 19:50
@nayr974 nayr974 added the pipeline change Change that updates the pipeline label Oct 17, 2024
@nayr974 nayr974 changed the title fix: Ce 1124 fix: CE 1124 Oct 17, 2024
Copy link

sonarcloud bot commented Oct 17, 2024

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with failing tests as they appear to be performance related and also this change doesn't really affect the app.

@afwilcox afwilcox merged commit a338648 into release/lions-mane-jellyfish Oct 17, 2024
14 of 15 checks passed
@afwilcox afwilcox deleted the CE-1124 branch October 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline change Change that updates the pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants