generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ce 478 #685
Merged
Merged
fix: Ce 478 #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dmitri-korin-bcps <108112696+dmitri-korin-bcps@users.noreply.github.com> Co-authored-by: gregorylavery <100631366+gregorylavery@users.noreply.github.com> Co-authored-by: Scarlett <35635257+Scarlett-Truong@users.noreply.github.com> Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com> Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca> Co-authored-by: jeznorth <twenty15creative@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <alecwilcox@gmail.com> Co-authored-by: Scarlett <scarlett.truong307@gmail.com>
…ation type of waste or pesticide in any region (#649) Co-authored-by: dmitri-korin-bcps <108112696+dmitri-korin-bcps@users.noreply.github.com> Co-authored-by: gregorylavery <100631366+gregorylavery@users.noreply.github.com> Co-authored-by: Scarlett <35635257+Scarlett-Truong@users.noreply.github.com> Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com> Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca> Co-authored-by: jeznorth <twenty15creative@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <alecwilcox@gmail.com> Co-authored-by: Scarlett <scarlett.truong307@gmail.com>
#632) Co-authored-by: Barrett Falk <bfalk@salussystems.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: dmitri-korin-bcps <108112696+dmitri-korin-bcps@users.noreply.github.com> Co-authored-by: Barrett Falk <bfalk@salussystems.com> Co-authored-by: gregorylavery <100631366+gregorylavery@users.noreply.github.com> Co-authored-by: Scarlett <35635257+Scarlett-Truong@users.noreply.github.com> Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca> Co-authored-by: jeznorth <twenty15creative@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <alecwilcox@gmail.com> Co-authored-by: Scarlett <scarlett.truong307@gmail.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca> Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca> Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
#663) Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: Barrett Falk <bfalk@salussystems.com> Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com> Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
… of offices not found within the organization selected (#664) Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca> Co-authored-by: afwilcox <alecwilcox@gmail.com>
…se. (#667) Co-authored-by: afwilcox <alecwilcox@gmail.com>
…r-CEEB (#678) Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
…ng invitation link (#680) Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
gregorylavery
changed the base branch from
release/orca
to
release/lions-mane-jellyfish
October 3, 2024 20:41
Quality Gate passedIssues Measures |
afwilcox
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resets the values for the long and lat when the user presses the 'cancel changes' button.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
The current code sets an interim value when the users changes the lat or long and then updates the map with that, when cancelling these values are retained when they should be reset to the originally saved values.
Test procedure:
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: