Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ce 478 #685

Merged
merged 23 commits into from
Oct 3, 2024
Merged

fix: Ce 478 #685

merged 23 commits into from
Oct 3, 2024

Conversation

gregorylavery
Copy link
Contributor

@gregorylavery gregorylavery commented Oct 2, 2024

Resets the values for the long and lat when the user presses the 'cancel changes' button.

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
The current code sets an interim value when the users changes the lat or long and then updates the map with that, when cancelling these values are retained when they should be reset to the originally saved values.

Test procedure:

  • Press 'Edit' on a complaint which as a lat and long
  • When the modal comes up edit/remove the values in lat and long, confirm the map shows a different location
  • Press the 'cancel changes' button and view the complaint to confirm it now has the original values and that the map it showing the previous/original location.
  • Press 'Edit' again to confirm the original values are shown in the Modal.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

barrfalk and others added 20 commits September 23, 2024 17:32
Co-authored-by: dmitri-korin-bcps <108112696+dmitri-korin-bcps@users.noreply.github.com>
Co-authored-by: gregorylavery <100631366+gregorylavery@users.noreply.github.com>
Co-authored-by: Scarlett <35635257+Scarlett-Truong@users.noreply.github.com>
Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: jeznorth <twenty15creative@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: Scarlett <scarlett.truong307@gmail.com>
…ation type of waste or pesticide in any region (#649)

Co-authored-by: dmitri-korin-bcps <108112696+dmitri-korin-bcps@users.noreply.github.com>
Co-authored-by: gregorylavery <100631366+gregorylavery@users.noreply.github.com>
Co-authored-by: Scarlett <35635257+Scarlett-Truong@users.noreply.github.com>
Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: jeznorth <twenty15creative@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: Scarlett <scarlett.truong307@gmail.com>
#632)

Co-authored-by: Barrett Falk <bfalk@salussystems.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: dmitri-korin-bcps <108112696+dmitri-korin-bcps@users.noreply.github.com>
Co-authored-by: Barrett Falk <bfalk@salussystems.com>
Co-authored-by: gregorylavery <100631366+gregorylavery@users.noreply.github.com>
Co-authored-by: Scarlett <35635257+Scarlett-Truong@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: jeznorth <twenty15creative@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: Scarlett <scarlett.truong307@gmail.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
#663)

Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: Barrett Falk <bfalk@salussystems.com>
Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
… of offices not found within the organization selected (#664)

Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
…se. (#667)

Co-authored-by: afwilcox <alecwilcox@gmail.com>
…r-CEEB (#678)

Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
…ng invitation link (#680)

Co-authored-by: afwilcox <alecwilcox@gmail.com>
Co-authored-by: afwilcox <alecwilcox@gmail.com>
@gregorylavery gregorylavery changed the base branch from release/orca to release/lions-mane-jellyfish October 3, 2024 20:41
Copy link

sonarcloud bot commented Oct 3, 2024

@gregorylavery gregorylavery marked this pull request as ready for review October 3, 2024 21:26
@nayr974
Copy link
Contributor

nayr974 commented Oct 3, 2024

Pulled locally and tested, confirmed lat/long were reverted to the original values:
image

@nayr974 nayr974 self-assigned this Oct 3, 2024
@afwilcox afwilcox merged commit 5e72328 into release/lions-mane-jellyfish Oct 3, 2024
22 checks passed
@afwilcox afwilcox deleted the CE-478 branch October 3, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants