Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-111: CEEB users brought to 'Access Denied' page when following invitation link #680

Conversation

barrfalk
Copy link
Collaborator

@barrfalk barrfalk commented Sep 27, 2024

Description

Issue was that users without an office results in null exceptions. Solution was to make the office an optional attribute for an officer. Search service needed to be updated to grab agency from role rather than office.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Remove office from officer. Verify application still works

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link

sonarcloud bot commented Oct 1, 2024

@afwilcox afwilcox merged commit dc3a466 into release/orca Oct 2, 2024
15 checks passed
@afwilcox afwilcox deleted the CE-1111-CEEB-users-brought-to-Access-Denied-page-when-following-invitation-link branch October 2, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants