Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CE-989 #587

Merged
merged 8 commits into from
Aug 15, 2024
Merged

fix: CE-989 #587

merged 8 commits into from
Aug 15, 2024

Conversation

gregorylavery
Copy link
Contributor

@gregorylavery gregorylavery commented Aug 13, 2024

Description

Changes how the phone number validation and the coordinate validation work in the import process. Updates the scripts to modify where the original functions were created rather than trying to add then update these functions.

Fixes # (issue)
CE-989, CE-965

How Has This Been Tested?

Created a number of records with invalid phone numbers and coordinates. Confirmed they now display properly in the app.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@barrfalk barrfalk merged commit c0216a7 into release/river-otter Aug 15, 2024
13 of 15 checks passed
@barrfalk barrfalk deleted the CE-989 branch August 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants