Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changes the phone number returned to be only 14 digits max. #585

Closed
wants to merge 4 commits into from

Conversation

gregorylavery
Copy link
Contributor

@gregorylavery gregorylavery commented Aug 9, 2024

Description

As per title - reduces the number of digits returned in the phone number to a + followed by 14 rather than 15 digits. The second execution path where the number doesn't start with a 1 is included and it reduces the number down to a +1 and 13 digits.

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)
CE-965

How Has This Been Tested?

Created a number of records with problematic numbers included and confirmed they appear as expected in the app.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link

sonarcloud bot commented Aug 12, 2024

@gregorylavery
Copy link
Contributor Author

Closing to recreate a new PR with changes for the phone number format in a single PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants