Feat/score proponent - Create endpoint #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sutherlanda
approved these changes
Aug 22, 2024
| Validation | ||
| } from "shared/lib/validation"; | ||
|
|
||
| function makeValidateSWUTeamQuestionResponseEvaluationEnum<T>( |
There was a problem hiding this comment.
Not sure if this is only used for making validators for response evaluations, but you could name it something more generic and make it available for other types of validators. Nothing seems strictly specific to response evaluations.
| @@ -462,3 +462,19 @@ export function validatePriceWeight(raw: string | number): Validation<number> { | |||
| export function validateNote(raw: string): Validation<string> { | |||
| return validateGenericString(raw, "Status Note", 0, 1000); | |||
| } | |||
|
|
|||
| export function validateSWUEvaluationPanelMemberEvaluator( | |||
| raw: any | |||
There was a problem hiding this comment.
If you want to avoid the use of any, unknown is a good alternative for a type here.
Comment on lines
+51
to
+55
| await connection.schema.raw(` \ | ||
| ALTER TABLE "swuOpportunityStatuses" \ | ||
| ADD CONSTRAINT "swuOpportunityStatuses_status_check" \ | ||
| CHECK (status IN ('${Object.values(SWUOpportunityStatus).join("','")}')) \ | ||
| `); |
There was a problem hiding this comment.
I don't think you need the \ 's to denote newlines since you are using backticks ` here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sutherlanda, not sure if you ran any migrations for the last meeting, but if you did, you should migrate down before applying these because I changed src/migrations/tasks/20240718222006_swu-evaluation-tables.ts.
There's a lot to critique, but I want to see if this create endpoint fits into the overall flow for "in-app evaluations" and if it fulfills some of the requirements we discussed last time; I'll try to map it to JIRA tickets when possible and I've included a rough diagram to try help you visualize things:
Assuming everything's good to go here, my plan is to:
FYI, I've tested this manually using postman and by manipulating the database, but I decided to hold back on automated tests because I wanted to make sure I was on the right track first. I'll include those in the next PR when we're on the same page.