fix bug #283
Closed
fix bug #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimCsaky
requested review from
norrisng-bc and
jatindersingh93
as code owners
Coverage Report
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/src/controllers/bucket.js
Outdated
| @@ -162,6 +162,7 @@ const controller = { | |||
| }); | |||
| } | |||
|
|
|||
| // TODO: give current user MANAGE perm on existing bucket (sub-folder) instead | |||
|
Code Climate has analyzed commit 977b6c9 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.1% (0.0% change). View more on Code Climate. |
| @@ -162,6 +162,7 @@ const controller = { | |||
| }); | |||
| } | |||
|
|
|||
| // TODO: give current user MANAGE perm on existing bucket (sub-folder) | |||
| steps: | ||
| # TODO: does pr-123 user need to own database pr-123 in order to connect run knex migrations? |
app/src/controllers/bucket.js
Outdated
| @@ -162,6 +162,7 @@ const controller = { | |||
| }); | |||
| } | |||
|
|
|||
| // TODO: give current user MANAGE perm on existing bucket (sub-folder) instead | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
Further comments