Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure PR Deployments to Share DEV master Postgres Cluster #282

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

TimCsaky
Copy link
Contributor

Description

Pipeline changes to:

  • not deploy a new crunchydb postgres cluster for PR deployments
  • on PR opended: add a database, user and role for the PR deployment of our app (eg: pr-123)
  • on PR closed: remove database, user and role for PR
  • let PR deployment of COMS app share postgres of DEV master release and connect using temporary postgres user (eg pr-123)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

insecure_skip_tls_verify: true
namespace: ${{ env.NAMESPACE_PREFIX }}-dev

# TODO: does pr-123 user need to own database pr-123 in order to connect run knex migrations?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

Copy link

codeclimate bot commented Oct 29, 2024

Code Climate has analyzed commit 76e774c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report

Totals Coverage
Statements: 61.06% ( 3045 / 4987 )
Methods: 50.99% ( 335 / 657 )
Lines: 68.14% ( 1831 / 2687 )
Branches: 53.5% ( 879 / 1643 )

@TimCsaky TimCsaky merged commit 8089370 into master Oct 29, 2024
12 of 13 checks passed
@TimCsaky TimCsaky deleted the pipeline branch October 29, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant