Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports Sign Off Page #2284

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Reports Sign Off Page #2284

merged 6 commits into from
Oct 2, 2024

Conversation

ayeshmcg
Copy link
Contributor

Card: bcgov/cas-reporting#207
Changes:

  • Added Sign Off Page
  • Added Schema for Sign off page
  • Modified MultiStepFormWithTaskList Component to have optional props
  • Modified format date file- added two more functions
  • Modified Formbase: added custom error for signature
  • Modified checkbox widget to have alignment option

dleard
dleard approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@dleard dleard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

@ayeshmcg ayeshmcg force-pushed the feat/207-report-sign-off-page branch from 987f943 to 528d26a Compare October 1, 2024 23:46
@ayeshmcg ayeshmcg merged commit ee791ae into develop Oct 2, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleard dleard dleard approved these changes

@joshgamache joshgamache Awaiting requested review from joshgamache

@pbastia pbastia Awaiting requested review from pbastia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayeshmcg @dleard