1879 edit operation

[marcellmueller]

#1879
To test this make sure to reset the database since it includes updated fixtures:

• cd bc_obps && make reset_db && make run
• Navigate to the Operations dashboard in the Administration module
• Select any Operation that has View Operation in the action column and click View Operation (made an issue to fix the Start Registration and Continue Registration URLs)
• Click Edit button at the bottom of the form
• Make any necessary changes (file upload fields will definitely be required)
• Click Submit
• The form should save. You can refresh the page and the updates will remain.

Other things to test:

• Click View Details for Operation 14 which has a purpose of Electricity Import Operation
• The Regulated product names field does not appear under Registration Purpose
• Return to Operations DataGrid, click View Details for Operation 14 which has a purpose of Potential Reporting Operation
• The Regulated product names field does not appear under Registration Purpose
• The Multiple Operators section works

[marcellmueller]

Added a new API route, though I was split on if I should add a query param like documents and return the documents if it was true. Can we have conditional Django Ninja schemas? Is a separate route fine?

[shon-button]

#1879

To test this make sure to reset the database since it includes updated fixtures:

• cd bc_obps && make reset_db && make run
• Navigate to the Operations dashboard in the Administration module
• Select any Operation that has View Operation in the action column and click View Operation (made an issue to fix the Start Registration and Continue Registration URLs)
• Click Edit button at the bottom of the form
• Make any necessary changes (file upload fields will definitely be required)
• Click Submit
• The form should save. You can refresh the page and the updates will remain.

Other things to test:

• Click View Details for Operation 14 which has a purpose of Electricity Import Operation
• The Regulated product names field does not appear under Registration Purpose
• Return to Operations DataGrid, click View Details for Operation 14 which has a purpose of Potential Reporting Operation
• The Regulated product names field does not appear under Registration Purpose

Issue Edited fields do not reflect entered values after page refresh

Test Steps

• Edited\completed fields: Process Flow Diagram*; Boundary Map*; Equipment List*;
• Clicked Submit
• Refreshed page
  

[shon-button]

@marcellmueller

Re #2287
FYI: Error is also seen on client.

[shon-button]

@marcellmueller

Q: are the uploaded files supposed to have download links?

Thanks

[marcellmueller]

@shon-button

There is a bug with the Read only file widget, it's not unique to this issue:
#2287

[marcellmueller]

@marcellmueller

Q: are the uploaded files supposed to have download links?

Thanks

49782dd

Added the file preview prop! Thanks.

[shon-button]

@marcellmueller

FYC, :)

Perhaps the backend service should verify that regulated_products should only be set for specific registration purposes (e.g., ELECTRICITY_IMPORT_OPERATION and POTENTIAL_REPORTING_OPERATION)

[marcellmueller]

I asked Brianna about this and she said not to worry about it seeing as all of the purpose conditionals are changing re: the business area.

[marcellmueller]

I added a comment here to remind us to potentially add that conditional in the future after the create registration purpose service gets redone. Thanks for the heads up, this was a good issue to raise 🙇

[shon-button]

@marcellmueller

nit: perhaps def test_industry_users_can_only_get_their_own_operations_with_documents(self) should be two separate tests:

def test_industry_user_can_get_owned_operation_with_documents(self):
def test_industry_user_cannot_get_unowned_operation_with_documents(self):

[marcellmueller]

I don't spend much time in here and was just following the patterns set in the get_operation test above this. However I can update this if you think it's a good use of my time.