chore: Wrap routes in suspense wrapper that haven't done so in child data components #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalcengio
force-pushed
the
2130-suspense-wrap
branch
4 times, most recently
from
568b794
to
aba736d
Compare
BCerki
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Looking good! 🤸
I think suspense may be missing from a couple files (but if it's in a child component and I just missed it, disregard):
- bciers/apps/reporting/src/app/bceidbusiness/industry_user/reports/[version_id]/facilities/[facility_id]/review/page.tsx
- bciers/apps/reporting/src/app/bceidbusiness/industry_user_admin/reports/[version_id]/facilities/[facility_id]/review/page.tsx
- anything that uses
OperationRegistrationPage(a PR to add a fetch to it just went in)
Yes I did miss those, you're right. I think I assumed they weren't calling anything because there was no async attached to the component. I'll have it included and pushed up soon |
gdalcengio
force-pushed
the
2130-suspense-wrap
branch
from
aba736d
to
37a3dc3
Compare
BCerki
approved these changes
Sep 20, 2024
gdalcengio
force-pushed
the
2130-suspense-wrap
branch
from
37a3dc3
to
e2fcc14
Compare
… suggested by Brianna
gdalcengio
force-pushed
the
2130-suspense-wrap
branch
from
e2fcc14
to
ce82f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2130