-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
324 update operation review #2174
Conversation
5468d45
to
47e28d9
Compare
7b4b599
to
e5ea9af
Compare
dd9f56f
to
9607320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! And good thinking about refactoring the page component to house the tasklist, the navigation and the form.
A few things:
- Missing tests for the MultiStepFormWithTaskList / MultiStepTaskListButton
- The MultiStepTaskListButton component isn't used anywhere, was it supposed to be in the MultiStepFormWithTaskList?
- I've left a lot of comments about error handling: I think that in general, we can leave it up to Django/React/Sentry to handle the "something went wrong on the network, in the database, or unexpected behaviour" errors. Surrounding code with a try/catch block in random places makes it difficult to get an accurate stack trace and error message once the code is in production.
The only errors we should catch are the ones part of the program flow, that we know will happen for certain cases.
bciers/apps/reporting/src/app/components/operations/OperationReview.tsx
Outdated
Show resolved
Hide resolved
bciers/libs/components/src/form/components/MultiStepTaskListButton.tsx
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/tests/components/OperationReview.test.tsx
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/tests/components/OperationReview.test.tsx
Outdated
Show resolved
Hide resolved
3402dc7
to
c013b05
Compare
028feff
to
63017c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! There's one last piece that needs to be ironed out, between facility_id and report_facility_id. We can pair on that if you'd like.
I'll preemptively approve it
bciers/apps/reporting/src/app/components/operations/PersonResponsible.tsx
Show resolved
Hide resolved
Modified Operation review chore:modified schema Added changes for save and continue Resolved errors chore:fixed person responsiblec component chore:fixed errors Fixed variable name issue
a4501cb
to
b89d22c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some leftover code to remove. The facility_report
api/service stuff has been split into its own separate files to separate the concerns from report_service functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Modified Operation Review Information page.
Changes include:
To test: