Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Application Tag Resource to Backend #1945

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

Abradat
Copy link
Collaborator

@Abradat Abradat commented Oct 30, 2024

Backend Changes:

  • Application_Tag Table (Many to Many relationship between application and tag entities)
  • ApplicationTagService
  • ApplicationTagController
  • ApplicationTagDTO

}

return application.tags && application.tags.length > 0
? application.tags.sort((a, b) => a.auditCreatedAt.getTime() - b.auditCreatedAt.getTime())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally think sorting should be done on the database.

trslater
trslater previously approved these changes Oct 31, 2024
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Abradat Abradat merged commit 8588367 into develop Oct 31, 2024
5 checks passed
@Abradat Abradat deleted the feature/ALCS-472-backend branch October 31, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants