Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for improved NOI structure text #1909

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Fixes for improved NOI structure text #1909

merged 10 commits into from
Oct 11, 2024

Conversation

trslater
Copy link
Collaborator

@trslater trslater commented Oct 10, 2024 •
edited
Loading

  • Update question wording on portal view, public view, alcs app info
  • Update structure types on ALCS
  • Update question wording for PDF's
  • Rename all occurences of structure type in ALCS
  • Update tests with new structure type names
  • Revert all renaming of structure types
  • Add new label mapping to shared constants
  • Map all existing NOI structure types to new labels

Note: I changed the way new structure type labels were mapped to avoid having to migrate existing structures text.

fbarreta
fbarreta approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@fbarreta fbarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@trslater trslater merged commit 69d0e4e into develop Oct 11, 2024
5 checks passed
@trslater trslater deleted the feature/ALCS-2149-2 branch October 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarreta fbarreta fbarreta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trslater @fbarreta