Springboot upgrade to 3.0.2 and also added github actions #62
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -15,7 +15,6 @@ | |||
| public class StudentProfileStatusCodeEntity { | |||
|
|
|||
| @Id | |||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | |||
There was a problem hiding this comment.
I needed to remove this because it was causing junit to fail. The h2 database was not able to process this annotation and the table never got created. It was something along the lines of varchar(255) not handled.
I see in genderCodesEntity that they do not need a generated value.
| this.entityManager.persist(this.document); | ||
| this.entityManager.flush(); | ||
| //document = this.repository.save(document); | ||
| this.entityManager.clear(); |
There was a problem hiding this comment.
I needed to rework this test since @dataJpaTests threw errors in the new springboot upgrade. Fix was to change the annotation to
@SpringBootTest(classes = {StudentProfileApiResourceApplication.class})
@activeprofiles("test")
however this meant that entityManager could no longer be autowired because it could not find a bean. So my fix was to save the test data to the repository directly.
rather than use entityManager.
No description provided.