-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grad release 1.11.0 #461
Merged
Merged
Grad release 1.11.0 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRAD2-2023: task is complete.
Removed the code smell & clean up debugging codes.
GRAD2-2023: task is complete.
…edits used for grad. GRAD2-2023: course with leftover credits is fixed to get the right credits used for grad.
GRAD2-2023: course with leftover credits is fixed to get the right cr…
…n grade 12 credits" GRAD2-2023: elective credits calculation is fixed to use up to the"min grade 12 credits"
GRAD2-2023: elective credits calculation is fixed to use up to the"mi…
GRAD2-2417: task is complete.
GRAD2-2417: task is complete.
GRAD2-2023: fixed the sorting order in minElectiveCredits1996Rule.
GRAD2-2023: fixed the sorting order in minElectiveCredits1996Rule.
…lation for grad on minGrade12Credit courses with leftover credits that are used twice in elective rule. GRAD2-2023: refactored not to use map1996 and fixed the credits calculation for grad on minGrade12Credit courses with leftover credits that are used twice in elective rule.
Trying to remove the code smells.
Trying to resolve duplicate code failure from sonar code quality.
Round 2 to resolve duplicate codes by sonar code quality.
…uality. Round 3: trying to resolve duplicate codes complained by sonar code quality.
GRAD2-2023: refactored not to use map1996 and fixed the credits calcu…
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grad release 1.11.0