Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grad release 1.11.0 #461

Merged
merged 18 commits into from
Dec 7, 2023
Merged

Grad release 1.11.0 #461

merged 18 commits into from
Dec 7, 2023

Conversation

kamal-mohammed
Copy link
Collaborator

Grad release 1.11.0

infstar and others added 18 commits November 27, 2023 14:57
GRAD2-2023: task is complete.
Removed the code smell & clean up debugging codes.
…edits used for grad.

GRAD2-2023: course with leftover credits is fixed to get the right credits used for grad.
GRAD2-2023: course with leftover credits is fixed to get the right cr…
…n grade 12 credits"

GRAD2-2023: elective credits calculation is fixed to use up to the"min grade 12 credits"
GRAD2-2023: elective credits calculation is fixed to use up to the"mi…
GRAD2-2417: task is complete.
GRAD2-2023: fixed the sorting order in minElectiveCredits1996Rule.
GRAD2-2023: fixed the sorting order in minElectiveCredits1996Rule.
…lation for grad on minGrade12Credit courses with leftover credits that are used twice in elective rule.

GRAD2-2023: refactored not to use map1996 and fixed the credits calculation for grad on minGrade12Credit courses with leftover credits that are used twice in elective rule.
Trying to remove the code smells.
Trying to resolve duplicate code failure from sonar code quality.
Round 2 to resolve duplicate codes by sonar code quality.
…uality.

Round 3: trying to resolve duplicate codes complained by sonar code quality.
GRAD2-2023: refactored not to use map1996 and fixed the credits calcu…
@kamal-mohammed kamal-mohammed merged commit 47edf5b into main Dec 7, 2023
2 checks passed
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants